Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOISSUE Detection of multiple custom theme folders #4076

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

NOISSUE Detection of multiple custom theme folders #4076

wants to merge 1 commit into from

Conversation

phit
Copy link
Contributor

@phit phit commented Sep 6, 2021

No description provided.

@phit
Copy link
Contributor Author

phit commented Sep 6, 2021 •
edited
Loading

do not merge yet, need to add fallback to a stock theme when the selected theme was deleted to
https://github.com/MultiMC/MultiMC5/blob/d644fb2094f623e45bff237ede7d432121f72072/launcher/MultiMC.cpp#L1145

also maybe fix the sorting of themes in the settings dropdown to be alphabetical by the display name of the theme

@ryleu
Copy link

ryleu commented Dec 25, 2021

You can make this a draft PR so that it doesn’t show as open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phit @ryleu